A synthesised base resolves under its bare name, and Heist Gear's own lines are not modifiers - #45

Release notes

• Fixed a synthesised weapon or armour piece (e.g. a synthesised Sceptre) failing to resolve its base, so pricing it now works the same as any other base.
• Fixed a Heist Gear item showing its own printed instructions ("Any Heist member can equip this item.", "Can only be equipped to Heist members.") as unrecognised modifiers.
• Fixed a Heist Contract affix with no roll at all (e.g. "Monsters are Hexproof", "The Ring takes no Cut") showing as an unrecognised modifier, in both price check and map check.

Review notes

ADDED:

• Three captures pinned against the bundle version each report was filed against, and the regression cases that check them
• A lexicon list, UnscalableSuffixes, naming every spelling of "this roll is fixed" the game appends to a modifier: the numeric "(unscalable value)" parenthetical, the em-dash "Unscalable Value" a modifier with no roll at all gets instead, and the plain-hyphen form Wine's clipboard fallback can turn the em dash into

CHANGED:

• The base line's "Synthesised " prefix is stripped before base lookup, the same as "Superior " already is — the bundle only ever knows a synthesised weapon or armour base under its bare name
• "Heist member" is a usage-note needle, so the two boilerplate lines every Heist Gear item prints are no longer read as unmatched modifiers
• The unscalable-suffix check now walks the lexicon's list instead of comparing against a single hardcoded constant, so a further spelling can be added without touching the matching code
• The test bundle slice gained Void Sceptre, Nebulis, Precise Arrowhead, Sceptres, Heist Gear and the Smuggler's Den contract's four affixes, plus the stats and heist mod-pool entries each capture needs, regenerated from the installed bundle matching the reports (20260813.55 predates the checkout's own out/, which has since drifted on an unrelated pair of logbook stats — left untouched)

7(7-6)% reduced Hiring Fee on the Heist Gear capture, called out as a data-bundle gap in an earlier revision of this PR, is now fixed on the data side (PathOfPriceCheck-Data main, no app change needed) and will resolve once that bundle ships.

Test plan

• ctest --test-dir build — all 24 targets pass, including the new regression cases